OS-2872

'vmadm list -p -o uuid,alias type=KVM' no longer returns results

Status:
Resolved
Resolution:
Fixed
Created:
2014-03-31T11:13:21.000-0400
Updated:
2018-05-07T13:50:29.740-0400

Description

Ante Vojvodic pointed out on smartos-discuss:

Hi,

after recent SmartOS upgrade this command stopped working:

#vmadm list -p -o uuid,alias type=KVM

but if we add type to output fields, it's working:

  1. vmadm list -p -o uuid,alias,type type=KVM
    596ca58e-6ad7-42dc-a39f-a1d4bacc5a7f:ubuntu-dev:KVM
    e12158a6-ddbf-4d1d-b0d8-1eeef8c55f8c:W7x86:KVM
    e7303b27-69b5-437b-b763-f2475b840730:ubuntu:KVM
    edabff7e-5b53-46d2-80aa-9f27b054aa43:centos-dev:KVM

After goring trough git log I found commit after which it stopped working.

commit 19463e8765691f980d8944fa91b6d80f3b4a55a6
Author: Josh Wilsdon <jwilsdon@joyent.com>
Date: Sat Mar 8 07:09:56 2014 +0000

OS-2772 vmadm refactor part 1: separate VM loading from VM.js

Now is this a bug or new expected behavior?

this is indeed a bug.

Comments (2)

Former user commented on 2014-04-01T03:02:03.000-0400:

smartos-live commit 6737ef4 (branch master, by Josh Wilsdon)

OS-2872#icft=OS-2872 fix list behavior when lookup key not in output list.

Josh Wilsdon commented on 2014-04-01T03:06:44.000-0400 (edited 2018-05-07T13:50:29.721-0400):

This was a regression. The problem was that while type=KVM was passed, nothing was ensuring that 'brand' was set which was required in order to properly set 'type'. I've fixed this by making 'type' depend on 'brand'. I've also fixed some related problems I found with ram/max_physical_memory while I was in this code.