MORAY-104: moray: disallow filtering on non-indexed fields except interactively

Details

Issue Type:New Feature
Priority:4 - Normal
Status:Resolved
Created at:2013-01-23T21:36:38.000Z
Updated at:2018-04-10T20:36:28.936Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2017-06-01T22:37:45.000Z)

Fix Versions

2017-06-08 SUDAN SURPRISE (Release Date: 2017-06-08)

Related Issues

Description

See MANTA-893.

Comments

Comment by Former user
Created at 2017-04-13T00:20:13.000Z

The changes required to fix this ticket are now described by RFD 78.

I'm currently working in joyent/node-moray, joyent/moray and joyent/moray-test-suite on implementing the changes presented by that RFD as a prototype, thus, I'm assigning this ticket to myself.


Comment by Former user
Created at 2017-05-30T00:20:26.000Z
Updated at 2017-05-30T00:23:20.000Z

The CRs linked to this issue (see above) have been tested by:

1. Running the new tests added in joyent/moray-test-suite in my COAL setup after upgrading Triton's Moray to an image built from MORAY-104's changes.

2. Running the full nightly-1 test jobs after upgrading Triton's Moray to an image built from MORAY-104's changes.

3. Running the manta-muskie tests suite both in COAL and in nightly-1 after upgrading both Triton's and Manta's moray to an image built from MORAY-104's changes.

The moray-test-suite tests all pass.

The Triton test jobs in nightly-1 didn't show any regression.

The manta-muskie tests suite yielded similar results in nightly-1 and COAL: all tests passed except for tests that were failing or stalling without the changes implemented by these CRs. These failing tests are:

1. job inputs - context change after job creation and job ok tests stall when waiting for the job to be done. I haven't had the time to investigate the root cause of this issue.

2. create upload: x-durability-level header and create upload: various headers sometimes fail with a NotEnoughSpace error. I also haven't had the time to investigate the root cause of this issue. FWIW, adding one storage node (from 2 to 3) seems to work around the problem.


Comment by Former user
Created at 2017-05-31T21:36:19.000Z

I was finally able to get all manta-muskie tests to pass in nightly-1 after provisioning all moray zones with an image built from a branch with the changes that fix MORAY-104, so the CRs linked to this ticket should be ready to integrate.


Comment by Former user
Created at 2017-06-01T18:25:09.000Z

I also implemented and successfully tested the changes for ZAPI-786, which require ZAPI-747 and the changes described in this ticket for both joyent/node-moray and joyent/moray. That allowed me to make sure that the new behavior and API implemented by these changes suit a concrete use case in Triton.


Comment by Former user
Created at 2017-06-01T22:33:51.000Z

moray commit 18fe21a (branch master, by Julien Gilli)

MORAY-104 moray: disallow filtering on non-indexed fields except interactively
Reviewed by: Cody Peter Mello <cody.mello@joyent.com>
Approved by: Cody Peter Mello <cody.mello@joyent.com>


Comment by Former user
Created at 2017-06-01T22:34:04.000Z

node-moray commit 791780c (branch master, by Julien Gilli)

MORAY-104 moray: disallow filtering on non-indexed fields except interactively
Reviewed by: Cody Peter Mello <cody.mello@joyent.com>
Reviewed by: David Pacheco <dap@joyent.com>
Approved by: Cody Peter Mello <cody.mello@joyent.com>


Comment by Former user
Created at 2017-06-01T22:34:18.000Z

moray-test-suite commit 8974734 (branch master, by Julien Gilli)

MORAY-104 moray: disallow filtering on non-indexed fields except interactively
Reviewed by: Cody Peter Mello <cody.mello@joyent.com>
Reviewed by: David Pacheco <dap@joyent.com>
Approved by: Cody Peter Mello <cody.mello@joyent.com>