OS-4960: in-gate dmake should be used to build the platform

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2015-11-16T20:15:34.000Z
Updated at:2019-02-28T19:52:15.610Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-02-28T19:52:15.597Z)

Fix Versions

2019-03-14 Night Cheese (Release Date: 2019-03-14)

Description

With the recent improvements it the in-gate dmake, it would be nice to use it for building illumos-joyent.

Comments

Comment by Former user
Created at 2015-12-08T19:21:04.000Z

It would be prudent to complete OS-5019 first to avoid hitting LWP limits with the more efficient dmake.


Comment by Dan McDonald
Created at 2018-05-08T17:23:56.435Z

Because in-gate dmake uses gettext(), it better reports errnos.  See the false-bug illumos#9523, e.g.


Comment by Former user
Created at 2019-01-08T19:55:14.977Z

To test this, I've done the following:

x gmake clobber before build
x full build non-debug
x gmake clobber after build
x full build debug
x gmake pkgsrc
x various test suites to sanity test
   - bhyvetesst
   - cryptotest
   - libctest
   - ostests had some failures I've seen before
   - utiltests 
   - vndtestt

Comment by Former user
Created at 2019-02-28T19:42:33.691Z
Updated at 2019-02-28T19:49:41.587Z

Heads up message that'll be sent out:

Hi all,

If you don't build the platform, then you don't need to take any action and can
choose to ignore the rest of this message.

With the integration of 'OS-4960 in-gate dmake should be used to build the
platform' (https://smartos.org/bugview/OS-4960), we have removed the remnants of
dmake that were in illumos-extra. In particular, that version existed before
dmake was integrated into illumos and does not have fixes for a number of bugs
and other issues that were cropping up in the build. To deal with this, there
are changes to the following repositories:

* smartos-live
* illumos-extra

You must update both repositories and rerun ./configure at
the top level.

Specifically, the following pattern should work for dealing with this flag day
(note all commands run from the root of smartos-live):

$ gmake clobber
$ gmake update
$ ./configure
$ gmake live

If you have any questions or concerns, please don't hesitate to reach out.

Thanks,
Robert

Comment by Jira Bot
Created at 2019-02-28T19:51:36.805Z

illumos-extra commit 5e30c479bc43ae6c7fd255de74e02fdc6a2314dd (branch master, by Robert Mustacchi)

OS-4960 in-gate dmake should be used to build the platform
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Approved by: John Levon <john.levon@joyent.com>


Comment by Jira Bot
Created at 2019-02-28T19:51:41.363Z

smartos-live commit 2655f721e6a7a52d9070654bc41772879bab1d15 (branch master, by Robert Mustacchi)

OS-4960 in-gate dmake should be used to build the platform
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Approved by: John Levon <john.levon@joyent.com>