OS-5723: ixgbe has uninitialized kstat fields

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2016-10-17T15:56:58.000Z
Updated at:2017-02-25T00:18:24.000Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2017-02-25T00:18:24.000Z)

Fix Versions

2017-03-02 KENYA OPTION (Release Date: 2017-03-02)

Description

ixgbe creates a kstat based on the ixgbe_stat structure -- but this structure has several fields that are only initialized if IXGBE_DEBUG is set rx_frame_error, rx_cksum_error, rx_exceed_pkt, tx_overload, tx_fail_no_tbd, tx_fail_no_tcb, tx_fail_dma_bind, tx_reschedule. The upshot is a zero'ed kstat that gets exported to user-level, potentially confusing kstat consumers that don't handle the edge case.

Comments

Comment by Former user
Created at 2017-02-25T00:18:17.000Z

illumos-joyent commit b3fbfca (branch master, by Ryan Zezeski)

OS-5723 ixgbe has uninitialized kstat fields
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Jerry Jelinek <jerry.jelinek@joyent.com>