OS-5934

As part of getting ready for UEFI support we need to update binutils to a version such that we can build the pei-x86-64 and pei-i386 targets.

It's suggested that we need at least 2.25.1 to have support for this, but it may be that if we're upgrading a newer version may also make sense. We may want to survey what other distros are using.

In addition, as part of this we need to make sure that this illumos#6653 (https://www.illumos.org/issues/6653) is fixed. This has been fixed in FBSD, so it should be as simple as pulling in the fix. See https://github.com/freebsd/freebsd/commit/bdbe7eaee6d095d91694b16f10fd0c3b90c0de20 for more information.

Former user commented on 2017-03-02T11:45:53.000-0500 (edited 2017-12-14T12:24:14.920-0500):

I have run a fresh build with the current binutils and then another one with the 2.25.1 version. I ran wsdiff but there are too many minor differences to really be certain of anything from this. However, from what I can see, it mostly looks like this are just small differences in locations of various symbols/addresses. I booted my smartos VM with this platform and everything seems to run ok. I booted an lx zone and successfully ran LTP. I ran DTrace, some SMF commands and mdb. Since this is the same version of binutils that OmniOS is using and I have the patch they are using, it seems like this is pretty safe to switch onto.

Former user commented on 2017-03-02T16:52:21.000-0500 (edited 2017-12-14T12:24:15.692-0500):

The ostests from illumos are currently broken (see OS-5993#icft=OS-5993) but once I hacked in a fix for that I ran the following tests on a platform with the current binutils and then one with the new binutils. I get the same results on both platforms (i.e. for the suites with failures, I get the same failures):

/opt/os-tests/bin/ostest
/opt/libc-tests/bin/libctest 
/opt/util-tests/bin/utiltest
/opt/SUNWdtrt/bin/dtest

Former user commented on 2017-03-06T10:38:20.000-0500: