OS-6761: hcksum routines are too verbose

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2018-03-12T23:25:45.371Z
Updated at:2019-02-05T22:19:01.942Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-02-05T22:19:01.927Z)

Description

The hcksum_assoc and hcksum_retreive functions feature special handling for M_MULTIDATA mblk handling which is no longer used by anything in the gate. Removing that logic would make their calls less verbose and marginally decrease the amount of work they must undertake.

Comments

Comment by Former user
Created at 2018-03-15T18:04:59.399Z

It turns out that some closed drivers that we ship make use of those old functions so they can't be changed. Switching in-gate consumers to the (more recent) mac_hcksum_* counterparts is an adequate substitute.


Comment by Former user
Created at 2018-03-16T22:01:41.897Z

I tested the fix for this (and OS-6762) with workloads running with and without VLANs between instances. Additionally, I floated the expected patch for OS-6701 over the top to further test the mac_hcksum_clone function, as it's essential to that fix. It worked as desired, too.


Comment by Jira Bot
Created at 2018-03-16T23:02:16.034Z

illumos-joyent commit 3c32c786cc014ec9aab1c7cb8f001b57359d506a (branch master, by Patrick Mooney)

OS-6761 hcksum routines are too verbose
OS-6762 want mac_hcksum_clone function
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Ryan Zezeski <rpz@joyent.com>
Approved by: Ryan Zezeski <rpz@joyent.com>