OS-6858: vmm tracing framework is dead code

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2018-03-30T20:33:33.610Z
Updated at:2018-04-03T17:47:30.243Z

People

Created by:Mike Gerdts [X]
Reported by:Mike Gerdts [X]
Assigned to:Mike Gerdts [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2018-04-03T17:47:30.232Z)

Fix Versions

2018-04-12 Promised Land (Release Date: 2018-04-12)

Related Links

Labels

bhyve

Description

The Pluribus port added vmm_trace_log(), which is now never called. This dead code should be removed. Since the vmm kernel module's only purpose is to access the logs that would be populated by vmm_trace_log() it will also be removed.

This removal is acknowledges the desire to a have ring-buffer based tracing feature in vmm. Per @bryan, that should be a lockless implementation like the one he wrote for kvm.  Not only is this implementation not lockless, but it also allocates memory in the middle of tracing.

Comments

Comment by Jira Bot
Created at 2018-04-03T17:45:14.523Z

illumos-joyent commit 7ab3f5348d729755d5a5fe1c679174b62ec4861e (branch master, by Mike Gerdts)

OS-6858 vmm tracing framework is dead code
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Approved by: Patrick Mooney <patrick.mooney@joyent.com>