OS-7395: bhyve: VM_{SUSPEND,RESUME}_CPU ioctls ignore vcpu argument

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2018-11-27T17:14:26.317Z
Updated at:2018-12-05T23:59:23.215Z

People

Created by:Hans Rosenfeld [X]
Reported by:Hans Rosenfeld [X]
Assigned to:Hans Rosenfeld [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2018-12-05T23:59:23.201Z)

Fix Versions

2018-12-06 Grizz (Release Date: 2018-12-06)

Related Links

Description

The two ioctls VM_SUSPEND_CPU and VM_RESUME_CPU don't read the vcpu argument passed in by libvmmapi, therefore always working on all vCPUs.

Comments

Comment by Hans Rosenfeld [X]
Created at 2018-12-05T11:22:35.560Z

Testing: I have tested this with the mdb bhyve target. Previously single-stepping wouldn't work reliably as all vCPUs would be resumed instead of just the one that was supposed to be single-stepped. With this change it works as expected. I'm not aware of any code depending on the broken behaviour.


Comment by Jira Bot
Created at 2018-12-05T23:01:02.841Z

illumos-joyent commit 4966850cbd32c33aeed41ff4610b6ac82c195962 (branch master, by Hans Rosenfeld)

OS-7395 bhyve: VM_{SUSPEND,RESUME}_CPU ioctls ignore vcpu argument
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Approved by: John Levon <john.levon@joyent.com>