OS-7446: clean up bhyve locking and names

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2018-12-13T22:07:40.192Z
Updated at:2018-12-18T21:59:00.784Z

People

Created by:Patrick Mooney [X]
Reported by:Patrick Mooney [X]
Assigned to:Patrick Mooney [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2018-12-18T21:59:00.771Z)

Fix Versions

2018-12-20 Hazel Wassername (Release Date: 2018-12-20)

Related Links

Labels

bhyve

Description

As bhyve has evolved to include functionality such as the sdev plugin, additional locks and driver-wide resources have been added. This has head to a mix of vmmdev_ and vmm_ prefixed resources which can be a little confusing at times. I drew up a wad to consolidate some of the naming and try to make it more consistent across the code.

Comments

Comment by Patrick Mooney [X]
Created at 2018-12-18T21:22:29.368Z

To test this, I booted up on a DEBUG-built platform with the changes and walked through various bhyve instance state transitions (startup, reboot, shutdown) to ensure that no lock invariants were broken and the instances ran as expected.


Comment by Jira Bot
Created at 2018-12-18T21:56:25.443Z

illumos-joyent commit 14f894282dbb1af80efba29ec886e852b04ca13c (branch master, by Patrick Mooney)

OS-7446 clean up bhyve locking and names
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Mike Gerdts <mike.gerdts@joyent.com>
Approved by: Mike Gerdts <mike.gerdts@joyent.com>