OS-7576: ctfdump -c should include non-root types

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2019-02-11T14:19:34.933Z
Updated at:2019-05-03T13:27:39.829Z

People

Created by:John Levon [X]
Reported by:John Levon [X]
Assigned to:John Levon [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-02-13T11:18:48.194Z)

Fix Versions

2019-02-14 Liz Lemon (Release Date: 2019-02-14)

Related Links

Description

As pointed out by rm, ctfdump -c is not including non-root types in its type output, and is thus missing a significant amount of types not directly referenced as a root type.

Comments

Comment by John Levon [X]
Created at 2019-02-11T15:57:31.116Z

To test this, I checked that the -p option still behaved sensibly with unix.
I compared old and new ctfdump -c options against gcc4 and gcc7 genunix's,
with diffs of the various outputs, to confirm it looked sensible.
I also did a quick old/new comparison against the whole of proto/ to verify
we didn't hit any obvious problems.


Comment by Jira Bot
Created at 2019-02-13T10:55:04.513Z

illumos-joyent commit 7d8f5232eba76666c623d07e4ae4401c00f43570 (branch master, by John Levon)

OS-7576 ctfdump -c should include non-root types
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>