OS-7653: ctf tools shouldn't add blank labels

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2019-03-11T18:15:20.087Z
Updated at:2019-03-20T18:54:22.133Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-03-20T18:54:22.123Z)

Fix Versions

2019-03-28 Operation Righteous Cowboy Lightning (Release Date: 2019-03-28)

Description

Today, when no label has been requested we end up creating a label section with an empty name. There's really no reason for such a label to exist. We should make this explicit and not have such empty labels when nothing has been passed in. If a user desired, they could still create a valid label with an empty name, though that feels of questionable utility.

Comments

Comment by Former user
Created at 2019-03-20T16:45:04.290Z

I tested this by making sure that there was no label section in generated CTF binaries.


Comment by Jira Bot
Created at 2019-03-20T18:54:15.291Z

illumos-joyent commit cab8f574b2799281fddf00931d5f96a163272c9a (branch master, by Robert Mustacchi)

OS-7645 ctf symbol mapping needs work
OS-7653 ctf tools shouldn't add blank labels
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: John Levon <john.levon@joyent.com>
Approved by: John Levon <john.levon@joyent.com>