OS-7719: PCIe speeds and feeds should be exposed to userland

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2019-04-09T01:02:54.891Z
Updated at:2019-06-21T17:54:25.865Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-06-21T17:54:19.072Z)

Fix Versions

2019-07-04 Verdukianism (Release Date: 2019-07-04)

Related Issues

Description

As part of our broader efforts around phy management, we should make sure to go through and expose PCIe link widths and supported speeds. While this was initially added to the kernel in OS-6229, the version in OS-6229 did not expose this information to user land and also never updated itself after discovering the device. This data should be updated whenever the link changes such as through mechanisms added in OS-7718.

Comments

Comment by Former user
Created at 2019-06-05T00:31:15.112Z
Updated at 2019-06-05T00:32:06.868Z

I tested this by booting these changes on a variety of different systems. I verified the following about different systems:


Comment by Jira Bot
Created at 2019-06-07T22:54:04.488Z

illumos-joyent commit e9799445816770d178ad6ee315d3b2e66d53fa29 (branch master, by Robert Mustacchi)

OS-7719 PCIe speeds and feeds should be exposed to userland
OS-7718 pcieb should enable link bandwidth notifications
OS-7742 Clean up pcieb CERRWARN and smatch
OS-7743 Clean up pcie module -Wno-uninitialized and -Wno-parentheses
Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Approved by: Rob Johnston <rob.johnston@joyent.com>


Comment by Former user
Created at 2019-06-08T01:29:17.335Z

While testing something else, I found this caused a panic on an AMD system. I've backed this out for the time being until I can figure out what's going on.


Comment by Jira Bot
Created at 2019-06-08T01:29:20.130Z

illumos-joyent commit 2cbcfc285b5e437a620b2eff0f206603f3f3b29a (branch master, by Robert Mustacchi)

backout: OS-7719 PCIe speeds and feeds should be exposed to userland (needs work)
Reviewed by: Bryan Cantrill <bryan@joyent.com>
Approved by: Bryan Cantrill <bryan@joyent.com>


Comment by Former user
Created at 2019-06-21T16:55:11.595Z

I ran through all the same testing again that I had last time, but also accounted for additional testing that triggered the issues enumerated in OS-7718 that had caused this to be backed out.


Comment by Jira Bot
Created at 2019-06-21T17:54:25.865Z

illumos-joyent commit c6ce7a25abbb33fa38edd55230b7992c5a36ce91 (branch master, by Robert Mustacchi)

OS-7719 PCIe speeds and feeds should be exposed to userland
OS-7718 pcieb should enable link bandwidth notifications
OS-7742 Clean up pcieb CERRWARN and smatch
OS-7743 Clean up pcie module -Wno-uninitialized and -Wno-parentheses
Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Approved by: Rob Johnston <rob.johnston@joyent.com>