OS-7769: Want Intel PCH temperature sensor

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2019-04-25T00:10:05.664Z
Updated at:2019-06-03T23:19:40.267Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-06-03T21:58:50.959Z)

Fix Versions

2019-06-06 TGS (Release Date: 2019-06-06)

Description

We'd like to add support for the temperature sensor that exists on various Intel chipsets, commonly called the platform controller hub in Intel parlance. Specifically this adds support for the various revisions that were introduced with Haswell. The sensor has a different format before that and currently isn't supported by the driver. This currently covers:

Comments

Comment by Former user
Created at 2019-06-03T18:22:42.411Z

I tested this by loading this on the following platforms which have the
following chipsets:

In each case I verified that the driver attached and we had output from
fmtopo and the temperature looked reasonable. When available, I double
checked that the temperature was close to that from another source like
IPMI.

I also checked that the following systems did not have a chipset node in
topo and the rest of the topo correctly enumerated:

Here's example output from a system of what now enumerates:

# /usr/lib/fm/fmd/fmtopo -V *chipset*
TIME                UUID
Jun 03 18:07:42 bf5aba3e-dba5-c56b-9a5a-d31941db7f46

hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0
    FRU               fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0
  group: authority                      version: 1   stability: Private/Private
    product-id        string    X10SLM+-LN4F
    chassis-id        string    0123456789
    server-id         string    haswell

hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:product-id=X10SLM+-LN4F:server-id=haswell:chassis-id=0123456789/motherboard=0/chipset=0?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    product-id        string    X10SLM+-LN4F
    chassis-id        string    0123456789
    server-id         string    haswell
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    43.500000

Comment by Jira Bot
Created at 2019-06-03T21:57:33.974Z

illumos-joyent commit 4726209a730fa4360258bd41e324d6fcd8c00269 (branch master, by Robert Mustacchi)

OS-7769 Want Intel PCH temperature sensor
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Approved by: Rob Johnston <rob.johnston@joyent.com>


Comment by Jira Bot
Created at 2019-06-03T21:58:07.484Z

smartos-live commit 2c4c6d3baff577029a86204faa7f1613e8151ec6 (branch master, by Robert Mustacchi)

OS-7769 Want Intel PCH temperature sensor
Reviewed by: Rob Johnston <rob.johnston@joyent.com>
Approved by: Rob Johnston <rob.johnston@joyent.com>


Comment by Jira Bot
Created at 2019-06-03T23:19:40.267Z

illumos-joyent commit 9240ea30ee29d2a499bcf3eed9e12dd9921f39f8 (branch master, by Robert Mustacchi)

OS-7769 Want Intel PCH temperature sensor (missing makefile)
Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
Approved by: Patrick Mooney <pmooney@pfmooney.com>