OS-7806: cannot move link from NGZ to GZ

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2019-05-22T00:18:12.296Z
Updated at:2019-06-20T12:12:18.635Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-06-20T12:12:18.620Z)

Fix Versions

2019-07-04 Verdukianism (Release Date: 2019-07-04)

Description

A link loaned to a non-global zone cannot be assigned back to the
global zone.

<GZ> root@testsos [~]
# dladm create-simnet test0

<GZ> root@testsos [~]
# dladm create-vnic -t -p zone=ba721f66-762f-4b38-9035-8c7359bdd1e8 -l test0 -v 5 test_vn0

<GZ> root@testsos [~]
# zlogin ba721f66-762f-4b38-9035-8c7359bdd1e8 ipadm create-addr -t -T static -a 192.168.99.99/24 test_vn0/v4

<GZ> root@testsos [~]
# dladm set-linkprop -t -z ba721f66-762f-4b38-9035-8c7359bdd1e8 -p zone=global test_vn0
dladm: warning: cannot set link property 'zone' on 'test_vn0': link busy

(1) <GZ> root@testsos [~]
# zlogin ba721f66-762f-4b38-9035-8c7359bdd1e8 ipadm delete-addr test_vn0/v4

<GZ> root@testsos [~]
# zlogin ba721f66-762f-4b38-9035-8c7359bdd1e8 ipadm delete-if test_vn0

<GZ> root@testsos [~]
# dladm set-linkprop -t -z ba721f66-762f-4b38-9035-8c7359bdd1e8 -p zone=global test_vn0
dladm: warning: cannot set link property 'zone' on 'test_vn0': link busy

This is due to code in dlmgmtd that harks back to the days when it was
responsible for deleting links loaned out to NGZs. But as part of
OS-5363 and OS-5919 we removed the old tombstone logic (ll_tomb)
and moved the NGZ VNIC deletion login into the platform shutdown code
where it belongs. In this current world there is no need to prevent
moving a link back to the GZ if it is no longer has any clients.

Comments

Comment by Former user
Created at 2019-06-18T21:28:16.646Z

I tested this by running the IP forwarding test suite, which cannot pass without moving a link from NGZ to GZ.


Comment by Jira Bot
Created at 2019-06-20T12:08:48.338Z

illumos-joyent commit 87738edeea3a17bfc0f19c6e1c3a597f3970e943 (branch master, by Ryan Zezeski)

OS-7520 OS-6778 broke IPv4 forwarding
OS-6878 mac_fix_cksum is incomplete
OS-7806 cannot move link from NGZ to GZ
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>