OS-7835: bhyve modules should have mapfiles

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2019-06-12T16:11:29.880Z
Updated at:2019-06-17T19:36:13.710Z

People

Created by:Patrick Mooney [X]
Reported by:Patrick Mooney [X]
Assigned to:Patrick Mooney [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-06-14T15:18:18.061Z)

Fix Versions

2019-06-20 Urban Fervor (Release Date: 2019-06-20)

Related Issues

Related Links

Labels

bhyve

Description

Especially given the FreeBSD compatibility functions it defines, the bhyve kernel module should use a mapfile to limit the symbols it exposes externally. Although few existing modules do this, it doesn't hurt to increase such cleanliness.

Comments

Comment by Patrick Mooney [X]
Created at 2019-06-12T18:41:53.976Z

To test this, I first built the modules in question using the change, checking with elfdump to see which symbols were globally visible. After confirming that the mapfiles were in effect, I booted a PI with the change and verified that those modules were able to successfully load. Quick functional tests of vmm and viona were straightforward to perform. I did not have easy access to hardware for testing ppt.


Comment by Patrick Mooney [X]
Created at 2019-06-13T18:34:47.357Z

An additional build-time test: I touched the mapfiles in question and verified that dmake rebuilt the final objects in question to reflect proper evaluation of the dependency.


Comment by Jira Bot
Created at 2019-06-14T15:16:51.081Z

illumos-joyent commit de37b27aa9332f8b33b7b4041b3bdaa6894dcde9 (branch master, by Patrick Mooney)

OS-7835 bhyve modules should have mapfiles
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Mike Gerdts <mike.gerdts@joyent.com>
Approved by: Mike Gerdts <mike.gerdts@joyent.com>