|Priority:||4 - Normal|
|Created by:||Patrick Mooney [X]|
|Reported by:||Patrick Mooney [X]|
|Assigned to:||Patrick Mooney [X]|
Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-06-14T15:18:18.061Z)
2019-06-20 Urban Fervor (Release Date: 2019-06-20)
Especially given the FreeBSD compatibility functions it defines, the bhyve kernel module should use a mapfile to limit the symbols it exposes externally. Although few existing modules do this, it doesn't hurt to increase such cleanliness.
To test this, I first built the modules in question using the change, checking with elfdump to see which symbols were globally visible. After confirming that the mapfiles were in effect, I booted a PI with the change and verified that those modules were able to successfully load. Quick functional tests of
viona were straightforward to perform. I did not have easy access to hardware for testing
An additional build-time test: I touched the mapfiles in question and verified that dmake rebuilt the final objects in question to reflect proper evaluation of the dependency.
illumos-joyent commit de37b27aa9332f8b33b7b4041b3bdaa6894dcde9 (branch master, by Patrick Mooney)
OS-7835 bhyve modules should have mapfiles
Reviewed by: Robert Mustacchi <firstname.lastname@example.org>
Reviewed by: John Levon <email@example.com>
Reviewed by: Mike Gerdts <firstname.lastname@example.org>
Approved by: Mike Gerdts <email@example.com>