OS-7945: kvm needs to be built with retpolines

Details

Issue Type:Improvement
Priority:4 - Normal
Status:Resolved
Created at:2019-08-09T21:36:18.840Z
Updated at:2019-10-07T12:29:15.424Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-10-07T12:29:15.407Z)

Fix Versions

2019-10-10 Close Talker (Release Date: 2019-10-10)

Description

Once OS-7598 is present, we'll need to update the kvm build to appropriately use retopolines.

Comments

Comment by Former user
Created at 2019-09-23T23:14:31.101Z

I gave this a quick sanity test on my system, and Ryan Kitchen also did some testing with various KVM images, including Windows.

I verified that the KVM source had no hand-written indirect jumps by 'dis' on the kvm module and essentially grepping for ' j.*%' as well as call instructions. So the only indirect jumps/calls were compiler-generated and the new flags are sufficient for this.

I also did a GCC4 build to check it worked OK still.


Comment by Jira Bot
Created at 2019-10-07T12:28:23.089Z

illumos-kvm commit 9ad0cc7792fc1f0e0fc8985ba8810362707b9b20 (branch master, by John Levon)

OS-7945 kvm needs to be built with retpolines
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Michael Zeller <mike.zeller@joyent.com>
Approved by: Jerry Jelinek <jerry.jelinek@joyent.com>