OS-7960: need fixes for NULL as a pointer

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2019-08-20T11:46:51.602Z
Updated at:2019-08-28T09:01:55.192Z

People

Created by:John Levon [X]
Reported by:John Levon [X]
Assigned to:John Levon [X]

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-08-28T09:01:55.176Z)

Fix Versions

2019-08-29 Zoo York (Release Date: 2019-08-29)

Related Links

Description

Downstream are planning to make NULL be a pointer not zero by default. We need a few fixes specific to illumos-joyent for this.

Comments

Comment by John Levon [X]
Created at 2019-08-22T12:10:59.976Z

To test mdb_v8: make prepush/test worked, and a quick sanity check of a PI with this version worked in MDB with ::jsstack, ::findjsobjects etc.


Comment by John Levon [X]
Created at 2019-08-27T15:38:24.768Z

I tested this by building from scratch with the null.h change, then verifying the resulting PI could go through a reflash, manta, etc.


Comment by John Levon [X]
Created at 2019-08-27T18:58:07.973Z

I also did a quick sanity provision of smartos, lx, kvm, and bhyve zones.


Comment by Jira Bot
Created at 2019-08-28T09:00:22.911Z

illumos-kvm commit cdb498cbb0432654d17a4bfff6e03cea99238ac9 (branch master, by John Levon)

OS-7960 need fixes for NULL as a pointer
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>


Comment by Jira Bot
Created at 2019-08-28T09:00:27.237Z

illumos-kvm-cmd commit 41e7c3e192eb39bb5ced7667fdc12ad2b33e646d (branch master, by John Levon)

OS-7960 need fixes for NULL as a pointer
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>


Comment by Jira Bot
Created at 2019-08-28T09:01:00.796Z

illumos-extra commit c86caaeaf063d7e33f180b1d18f1b149a79a9ee1 (branch master, by John Levon)

OS-7960 need fixes for NULL as a pointer
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>


Comment by Jira Bot
Created at 2019-08-28T09:01:30.660Z

illumos-joyent commit fa1252de73f343f36bf1e6f366902ba96c480aaa (branch master, by John Levon)

OS-7960 need fixes for NULL as a pointer
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Ryan Zezeski <rpz@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>