OS-8267: New ksh93 breaks gcc4 build

Details

Issue Type:Bug
Priority:4 - Normal
Status:Resolved
Created at:2021-02-11T15:38:08.896Z
Updated at:2022-05-12T18:00:36.590Z

People

Created by:Dan McDonald
Reported by:Dan McDonald

Related Links

Description

We need to be clever about how clever the aso FEATURE macros in the new ksh/libast are, because we still (in Jenkins, and on older revisions of SmartOS) allow building illumos with illumos-gcc4.

Comments

Comment by Dan McDonald
Created at 2021-02-11T16:15:14.083Z

Tested by building nightly on gcc7, and comparing with pre-this-fix libast.so.1 for amd64 and i386.  LITERALLY no differences between the two binaries.


Comment by Jira Bot
Created at 2021-02-11T16:19:03.075Z

illumos-joyent commit a4b5adf38c4d13d8a0bb4c581f0001585cc2ad4e (branch master, by Dan McDonald)

OS-8267 New ksh93 breaks gcc4 build

Reviewed by: Jason King <jbk@joyent.com>
Approved by: Jason King <jbk@joyent.com>


Comment by Jira Bot
Created at 2021-02-11T16:20:27.274Z

illumos-joyent commit 2f1bf94956d3fe3e668d961403094aa32964d7c1 (branch release-20210211, by Dan McDonald)

OS-8267 New ksh93 breaks gcc4 build

Reviewed by: Jason King <jbk@joyent.com>
Approved by: Jason King <jbk@joyent.com>


Comment by Dan McDonald
Created at 2022-05-12T18:00:36.590Z

Fixed in release-20210211.