OS-8401: vmm_drv_test needs to be less IPS-dependent

Details

Issue Type:Improvement
Priority:5 - Low
Status:Resolved
Created at:2022-08-03T20:16:19.176Z
Updated at:2022-08-03T21:03:40.520Z

People

Created by:Dan McDonald
Reported by:Dan McDonald
Assigned to:Dan McDonald

Description

Filing this as a distinct bug, so it can be extracted and upstreamed to -gate if need be.

Normally this would be a fix-in-merge, but the recent push of 14864 didn’t take into account that not all distros pull from IPS. An earlier fix in testing (part of 12830) also provided a device, but used the testing mechanisms to load-and-unload the driver in question. This bug tracks implementing the use of vmm_drv_test the same way ksensor_test does.

Ideally once this works in SmartOS, it can be upstreamed to -gate.

[https://www.illumos.org/issues/12830|https://www.illumos.org/issues/12830|smart-link]
[https://www.illumos.org/issues/14864|https://www.illumos.org/issues/14864|smart-link]

Comments

Comment by Dan McDonald
Created at 2022-08-03T20:54:40.115Z

It passed the tests it’s supposed to pass:

Starting test for bhyvetest with /opt/bhyve-tests/bin/bhyvetest
Test: /opt/bhyve-tests/tests/mevent/vnode_zvol (run as root)      [00:02] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/rdmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/wrmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/triple_fault (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vatpit_freq (run as root)       [00:00] [FAIL]
Test: /opt/bhyve-tests/tests/kdev/vhpet_freq (run as root)        [00:00] [FAIL]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq (run as root)       [00:00] [FAIL]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq_periodic (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_mmio_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_msr_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vpmtmr_freq (run as root)       [00:00] [FAIL]
Test: /opt/bhyve-tests/tests/mevent/lists_delete (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_disable (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_pause (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_requeue (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/vnode_file (run as root)      [00:09] [PASS]
Test: /opt/bhyve-tests/tests/viona/interface_version (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/vmm_drv_test_init (run as root)  [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/auto_destruct (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/drv_hold (run as root)           [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/fpu_getset (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/interface_version (run as root)  [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_devmem (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_partial (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_seg_map (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/vmm_drv_test_fini (run as root)  [00:00] [PASS]

Results Summary
PASS	  22
FAIL	   4

The failures are LIKELY because I’m running on a VMware VM.