TRITON-1621: updating SDC agents should not update Marlin agent

Details

Issue Type:Bug
Priority:3 - Elevated
Status:Resolved
Created at:2015-02-27T20:03:43.000Z
Updated at:2020-04-03T19:35:58.992Z

People

Created by:Former user
Reported by:Former user
Assigned to:Pedro Palazón Candel

Resolution

Duplicate: The problem is a duplicate of an existing issue.
(Resolution Date: 2020-04-03T19:35:37.553Z)

Related Issues

Description

The deployment of CM-231 last night triggered an update of the Marlin agents, which resulted in retries in a number of Manta jobs. This cascaded with MANTA-2531, causing various subsequent jobs to fail.

Until recently, agent install/deployment worked like this:

This is deeply suboptimal, but basically worked. I think what's changed is that "sdcadm update" always updates all of the agents.

I think the right long-term answer is for SAPI to support managing agents just like zones: you could list instances and their versions and upgrade individual agents. I'm not sure if this is already implemented -- SAPI-38 was supposed to cover this. That ticket was resolved, but there's no apparent code change so I'm not sure what the status is.

With the SAPI support integrated, the Manta deployment tooling could deploy the Marlin agent only on the boxes it should be on, and it could upgrade it as well. We can implement this without SAPI support (by teaching the Manta deployment tools about the agent and then using "sdc-oneachnode") but that feels like a lot of duplicated work (that will be thrown away) if we believe the SAPI option is the right way forward.

Comments

Comment by Former user
Created at 2015-06-02T23:28:10.000Z

Another unscheduled update of the Marlin agent happened again under CM-288.


Comment by Former user
Created at 2019-04-11T21:38:52.098Z

I think this has been obviated by subsequent work.  @accountid:557058:8e9a30b7-b0e0-4093-927b-6497faf34a80, does this ticket still make sense?


Comment by Former user
Created at 2019-04-12T00:00:07.895Z

This still makes sense if/until RFD 82 is done. RFD 82 is the ability to update individual agents, which is experimentally there as "sdcadm experimental update AGENT". However, the blessed path for installing and updating agents is still via the agentsshar, which still includes the marlin agent (https://github.com/joyent/sdc-agents-installer/blob/f85758a3b432e9b4b4e83ffe85bbc3684b985e3e/agents.json#L11).


Comment by Pedro Palazón Candel
Created at 2020-04-03T19:07:58.788Z

This is MANTA-4798


Comment by Former user
Created at 2020-04-03T19:09:02.084Z

Definitely will be done via that other ticket. Perhaps more of a "dupe" than "fixed" here. ;)


Comment by Pedro Palazón Candel
Created at 2020-04-03T19:35:58.992Z

Ok, let's flag it as dupe :-)