TRITON-1915: v8plus port to Linux


Issue Type:New Feature
Priority:4 - Normal
Created at:2019-10-04T21:46:06.835Z
Updated at:2019-10-16T18:07:15.787Z


Created by:Former user
Reported by:Former user
Assigned to:Former user


Won't Do: This issue won't be actioned.
(Resolution Date: 2019-10-16T18:07:15.773Z)

Related Issues




The cn-agent port to Linux requires node-lockfd, which requires v8plus.


Comment by Former user
Created at 2019-10-04T21:47:03.941Z

Work has begun:

Comment by Former user
Created at 2019-10-04T21:49:53.783Z

@accountid:6248927d45ece00069cb9db5 I think you might be able to just drop the lockfd dep. AFAICT cn-agent code isn't using it.

Comment by Former user
Created at 2019-10-04T21:52:23.792Z

If you can at all, I'd avoid v8plus and, if possible, replace it with more modern NAN usage. v8plus isn't maintained and likely never will be.

Comment by Former user
Created at 2019-10-07T16:23:56.441Z

There's some docker code in cn-agent that is using file locks. It looks like node-fs-ext may be a much simpler replacement for node-lockfd + v8plus. It seems portable across SmartOS and Linux. The portability story on archaeologically interesting versions of node has not been explored.

Comment by Former user
Created at 2019-10-07T17:32:31.475Z

Ah, I missed that because sdc-cn-agent.git has commited files under node_modules:

$ git ls-files node_modules/

which surprised my typical grepping. Sorry about that.

Comment by Former user
Created at 2019-10-16T18:07:15.785Z

Instead of this, locker.js is becoming node-qlocker, which will be portable. See TRITON-1941 and TRITON-1942.