ZAPI-666: refactor handling of curl HEAD requests

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2016-06-21T21:35:57.000Z)

Fix Versions

2016-06-23 Rock n' Rummy (Release Date: 2016-06-23)

Description

https://github.com/joyent/sdc-vmapi/blob/46b7515d8d2212f240bbdb6d6722774b9776fcbe/lib/endpoints/vms.js#L208-L214

That block is dumb. It was added in a commit with no commit message. Lacking
reason to keep it (I don't see how keep-alive is breaking curl usage of VMAPI)
I vote for dropping it.

Comments

Comment by Julien Gilli [X]
Created at 2016-06-16T01:53:49.000Z
It turns out that block was needed to fix ZAPI-220. However, as I mentioned in ZAPI-220, it seems that the way that issue was fixed is not ideal. I submitted another PR that attempts at improving the way VMAPI handles HEAD requests from curl clients.

Comment by Bot Bot [X]
Created at 2016-06-21T21:28:45.000Z

sdc-vmapi commit 9491fc3 (branch master, by Julien Gilli)

ZAPI-666: refactor handling of curl HEAD requests

    Reviewed-By: Josh Wilsdon <jwilsdon@joyent.com>


Comment by Bot Bot [X]
Created at 2016-06-22T19:37:24.000Z

sdc-vmapi commit b041e25 (branch master, by Julien Gilli)

ZAPI-666: fix tests in nightly

    Reviewed by: Trent Mick <trentm@gmail.com>


Comment by Bot Bot [X]
Created at 2016-06-22T19:58:13.000Z

sdc-vmapi commit 354e119 (branch master, by Julien Gilli)

ZAPI-666: fix tests in nightly (bis)

    Reviewed by: Trent Mick <trentm@gmail.com>


Comment by Bot Bot [X]
Created at 2016-06-22T20:00:16.000Z

sdc-vmapi commit f9fec54 (branch release-20160625, by Julien Gilli)

ZAPI-666: fix tests in nightly (bis)

    Reviewed by: Trent Mick <trentm@gmail.com>