TRITON-2011: remove dependency on node-lockfd

Details

Issue Type:New Feature
Priority:4 - Normal
Status:Resolved
Created at:2019-12-04T15:49:14.345Z
Updated at:2019-12-06T15:18:04.133Z

People

Created by:Former user
Reported by:Former user
Assigned to:Former user

Resolution

Fixed: A fix for this issue is checked into the tree and tested.
(Resolution Date: 2019-12-06T15:18:04.125Z)

Fix Versions

2020-01-02 Importer Exporter (Release Date: 2020-01-02)

Related Links

Labels

linuxcn

Description

The Linux port of cn-agent becomes easier if the dependency on node-lockfd is removed, as that means that v8plus does not need to be ported.

node-qlocker was developed specifically for this purpose and cn-agent should start to use it.

Comments

Comment by Former user
Created at 2019-12-04T18:38:25.460Z

I tested this with:

curl -kO  https://us-east.manta.joyent.com/Joyent_Dev/public/builds/agentsshar/master-TRITON-2011-master-20191204T162050Z-g643e1bf/agentsshar/agents-master-TRITON-2011-master-20191204T162119Z-g643e1bf.sh
sdcadm experimental update-agents  ./agents-master-TRITON-2011-master-20191204T162119Z-g643e1bf.sh cn2

The locking seems to be specific to operations that involve docker run -it ..., which I verified is still working fine. Aside from that, the agent appears to be healthy (no cores, sdcadm health ok, able to deploy non-docker instances).


Comment by Jira Bot
Created at 2019-12-06T15:15:30.171Z

sdc-cn-agent commit 169faeecfb407c763a8d0aaba516d0d6516ae8b8 (branch master, by Mike Gerdts)

TRITON-2011 remove dependency on node-lockfd (#24)

Reviewed by: Todd Whiteman <todd.whiteman@joyent.com>